Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/291: Add check for empty default attribute in Repeater component #292

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

Sidsector9
Copy link
Member

Description of the Change

Also pushes {} instead of [] on addItem when the default array is empty.

Closes #291

How to test the Change

Please follow the issue for steps to reproduce the issue.

Changelog Entry

Fixed - Add check for empty default attribute in Repeater component

Credits

Props @ocean90 @tlovett1 @Sidsector9

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

Size Change: +12 B (0%)

Total Size: 65.5 kB

Filename Size Change
dist/index.js 65.5 kB +12 B (0%)

compressed-size-action

@Sidsector9 Sidsector9 self-assigned this Jan 31, 2024
@fabiankaegy fabiankaegy merged commit f1c6e4e into develop Jan 31, 2024
5 of 6 checks passed
@fabiankaegy fabiankaegy deleted the fix/291 branch January 31, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeater: It's no longer possible to have an empty default state
2 participants